fix: improve k8s-dqlite node removal handling#2588
Open
claudiubelu wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
release-notes
claudiubelu
force-pushed
the
k8sd-node-removal-to-release-1.35
branch
2 times, most recently
from
a0d3b61 to
8c333d9
Compare
`dqlite.Client.RemoveNodeByAddress` now returns `ErrNotFound` error if the member is not found. This error is now being handled properly in `removeNodeFromK8sDqlite` (`cluster_remove.go`). By doing so, we're making the k8s-dqlite node removal operation idempotent on subsequent calls. Signed-off-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
claudiubelu
force-pushed
the
k8sd-node-removal-to-release-1.35
branch
from
8c333d9 to
5016b30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When removing a Kubernetes cluster node, if the node is no longer present in the k8s-dqlite cluster, we can consider that a success, since that's the desired outcome.
Solution
dqlite.Client.RemoveNodeByAddressnow returnsErrNotFounderror if the member is not found. This error is now being handled properly inremoveNodeFromK8sDqlite(cluster_remove.go).By doing so, we're making the k8s-dqlite node removal operation idempotent on subsequent calls.
Issue
Backport
Not applicable to main / k8sd,
removeNodeFromDatastoreonly handlesetcdandexternal.Can be backported to release-1.34.
Checklist
type: titlerelease-noteslabel should be kept or removed - N/AIf any item on the checklist is not complete, please provide justification why.